Fix: Launch the python backend on Windows when spaces exist in the path. #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yinggeh Hi, wondering if you could take a look at this PR I have created. A relatively simple fix to make things work smoothly on Windows. |
|
@vinitkmagnet Thanks. Can you rebase your change to branch https://github.com/triton-inference-server/python_backend/tree/mwittwer/explicit_model_load_parsing? |
|
Hi @yinggeh and @mattwittwer, I have created a new PR in to the requested branch #412. Hope this is what you were requesting. If not, let me know and I can correct my mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were no quotes around any of the paths in the stub launcher. As a result, if you tried launching the stub, it would always fail. Normally this is not an issue in Linux, but having spaces is very common in Windows. Added quotes around all the pathing of the launcher code to resolve this problem.